Forums / Extensions / Ezapprove2 improvements

Ezapprove2 improvements

Author Message

Matteo Mosangini

Wednesday 22 July 2009 2:22:23 am

Hi,

this is my first post in this forum.
I'm working on ezapprove2 extension you can find the code here:

https://git.e-moka.net/?p=approve2.git;a=summary

modifications:

- when you deny an object it is sent back to the author as a draft
- exclusion groups are applied even when you let your users select their approvers
- when an approver edits an item it is immediately published
- cleanup collaboration tables
- Italian translation
- template update

Heath

Wednesday 22 July 2009 4:20:30 am

Good to hear!

I also have an interest in these improvements.

Please drop an update as your changes evolve.

Cheers,
Heath

Brookins Consulting | http://brookinsconsulting.com/
Certified | http://auth.ez.no/certification/verify/380350
Solutions | http://projects.ez.no/users/community/brookins_consulting
eZpedia community documentation project | http://ezpedia.org

Matteo Mosangini

Thursday 23 July 2009 5:56:47 am

Extension updated!
Check out commit history:)

James

Thursday 23 July 2009 6:17:46 am

Wow that is an impressive collection of updates, congratulations.

[0] <i>https://git.e-moka.net/?p=approve2.git;a=blobdiff;f=eventtypes/event/ezapprove2/ezapprove2type.php;h=6f7448987a9a2db1af8ac03b2b20ee8c310d063d;hp=76c5cdf7e54ed91c73fe483732df66e27467628e;hb=289130036f2b7d1bfe8afde1b0f4e0026526fbff;hpb=e32f4a75180ec7b163ebe39b435fbce17b7734ef</i>

I'm not sure if the link will store correctly since its so unique but this is a direct link to a diff between first and current latest version of a primary ezapprove2 workflow event php file. The following is a changelog view.

[1] <i>https://git.e-moka.net/?p=approve2.git;a=log;h=1a4c0f10d4c17ca20b8a2875d93ebe888dc7a690</i>

Matteo Mosangini

Friday 24 July 2009 12:45:27 am

Webdav support in eZApprove2Event::ApproveTypeUser added.

Matteo Mosangini

Tuesday 18 August 2009 1:56:41 pm

Added configuration setting to enable per user class pre selection of approvers start browse node (during approvers selection)
Added template path in ezapprove2type

Heath

Wednesday 19 August 2009 12:47:25 am

Hello Matteo,

You have I wonder if you would consider speaking with YMC

Regarding collaboration on setting up a public mirror of your repository through, http://git.forge.ymc.ch/

This would ensure the community would not risk loosing these contributions in the future.

What do you think?

Cheers,
Heath

[0] http://ezpedia.org/ez/git
[1] http://git.forge.ymc.ch/

Brookins Consulting | http://brookinsconsulting.com/
Certified | http://auth.ez.no/certification/verify/380350
Solutions | http://projects.ez.no/users/community/brookins_consulting
eZpedia community documentation project | http://ezpedia.org

Matteo Mosangini

Thursday 27 August 2009 10:55:01 am

This could be very nice:)
Now I'm very busy, next week I'll try to speak to YMC.

Matteo Mosangini

Saturday 05 September 2009 6:06:10 am

I've contacted Ymc and now I'm waiting for an answer.

Meanwhile I added the possibility to save a list of previously used approvers (per user) to use during approvers selection

Thomas Koch

Sunday 06 September 2009 6:42:38 am

Hi Matteo,

I've cloned your repository at
http://git.forge.ymc.ch/
It'll be updated every 2 hours.

Please note, that this is an unofficial service of YMC and may (and will) change without warning. We're happy to help you (and the community) out with a backup.
However, since GIT is distributed, there's no reason not to put another backup for example at github, as I've done with eZ Components:
http://github.com/thkoch2001

Could you please add license information to the code so that's clear that we may actually distribute it?

---
Thomas Koch | http://koch.ro
YMC - eZ Publish in Switzerland | http://ymc.ch

Matteo Mosangini

Monday 07 September 2009 8:41:10 am

Hi Thomas,
I added license information, thank you very much for cloning my rep.

Jérôme Vieilledent

Thursday 07 January 2010 12:38:27 am

Hi

It would be interesting to have your changes committed in the original project repository, wouldn't it ?

Pablo Pernot

Friday 02 April 2010 1:44:00 am

"

Hi

It would be interesting to have your changes committed in the original project repository, wouldn't it ?

"

+1

Pablo Pernot
http://www.smartview.fr
http://www.areyouagile.com

Pablo Pernot

Friday 02 April 2010 5:21:48 am

Hum....

[ Apr 02 2010 14:15:27 ] [::1] eZMySQLDB:Query error: La table '*******.ezx_chosen_approver' n'existe pas. Query: SELECT id, user_id, approver_user_id FROM ezx_chosen_approverWHERE user_id='1030'

obviously the table ezx_chosen_approver is missing ? No table with that name un sql/schema.sql

any hints ?

Pablo Pernot
http://www.smartview.fr
http://www.areyouagile.com

Pablo Pernot

Friday 02 April 2010 5:29:16 am

hum... twice

probably a mistake from me

I find that :

https://git.e-moka.net/?p=approve2.git;a=blob;f=sql/mysql/ezx_chosen_approver.sql;h=be1b201216843ab00ec57d19b91e83bb9208a4b7;hb=e0e86d391baf161db9dcf71b4ee8d9c467251c7e

Pablo Pernot
http://www.smartview.fr
http://www.areyouagile.com

Samuel Torton

Tuesday 12 October 2010 2:15:19 pm

Hi Matteo,
I'm really interested in your eZ Approve 2 improvements. I will test it.
I have a concern regarding the 2 following improvements:
-1- exclusion groups are applied even when you let your users select their approvers
-2- when an approver edits an item it is immediately published
I really want NOT TO APPLY the point -2-, except if the approver is a member of -1-.
Could you please give me the hint concerning this point? And I will modify the code to meet my requirements.
Thank you,

Samuel Torton

eZ debug

Timing: Jan 18 2025 00:05:41
Script start
Timing: Jan 18 2025 00:05:41
Module start 'content'
Timing: Jan 18 2025 00:05:41
Module end 'content'
Timing: Jan 18 2025 00:05:42
Script end

Main resources:

Total runtime0.1454 sec
Peak memory usage4,096.0000 KB
Database Queries141

Timing points:

CheckpointStart (sec)Duration (sec)Memory at start (KB)Memory used (KB)
Script start 0.00000.0072 591.3203181.6719
Module start 'content' 0.00720.0048 772.9922118.3906
Module end 'content' 0.01200.1333 891.3828546.7500
Script end 0.1453  1,438.1328 

Time accumulators:

 Accumulator Duration (sec) Duration (%) Count Average (sec)
Ini load
Load cache0.00382.6118200.0002
Check MTime0.00151.0237200.0001
Mysql Total
Database connection0.00080.561310.0008
Mysqli_queries0.103070.81361410.0007
Looping result0.00110.75151390.0000
Template Total0.133091.410.1330
Template load0.00090.624610.0009
Template processing0.132090.817210.1320
Override
Cache load0.00060.429110.0006
Sytem overhead
Fetch class attribute can translate value0.00090.596210.0009
XML
Image XML parsing0.00030.222210.0003
General
dbfile0.00281.9524200.0001
String conversion0.00000.003430.0000
Note: percentages do not add up to 100% because some accumulators overlap

CSS/JS files loaded with "ezjscPacker" during request:

CacheTypePacklevelSourceFiles
CSS0extension/community/design/community/stylesheets/ext/jquery.autocomplete.css
extension/community_design/design/suncana/stylesheets/scrollbars.css
extension/community_design/design/suncana/stylesheets/tabs.css
extension/community_design/design/suncana/stylesheets/roadmap.css
extension/community_design/design/suncana/stylesheets/content.css
extension/community_design/design/suncana/stylesheets/star-rating.css
extension/community_design/design/suncana/stylesheets/syntax_and_custom_tags.css
extension/community_design/design/suncana/stylesheets/buttons.css
extension/community_design/design/suncana/stylesheets/tweetbox.css
extension/community_design/design/suncana/stylesheets/jquery.fancybox-1.3.4.css
extension/bcsmoothgallery/design/standard/stylesheets/magnific-popup.css
extension/sevenx/design/simple/stylesheets/star_rating.css
extension/sevenx/design/simple/stylesheets/libs/fontawesome/css/all.min.css
extension/sevenx/design/simple/stylesheets/main.v02.css
extension/sevenx/design/simple/stylesheets/main.v02.res.css
JS0extension/ezjscore/design/standard/lib/yui/3.17.2/build/yui/yui-min.js
extension/ezjscore/design/standard/javascript/jquery-3.7.0.min.js
extension/community_design/design/suncana/javascript/jquery.ui.core.min.js
extension/community_design/design/suncana/javascript/jquery.ui.widget.min.js
extension/community_design/design/suncana/javascript/jquery.easing.1.3.js
extension/community_design/design/suncana/javascript/jquery.ui.tabs.js
extension/community_design/design/suncana/javascript/jquery.hoverIntent.min.js
extension/community_design/design/suncana/javascript/jquery.popmenu.js
extension/community_design/design/suncana/javascript/jScrollPane.js
extension/community_design/design/suncana/javascript/jquery.mousewheel.js
extension/community_design/design/suncana/javascript/jquery.cycle.all.js
extension/sevenx/design/simple/javascript/jquery.scrollTo.js
extension/community_design/design/suncana/javascript/jquery.cookie.js
extension/community_design/design/suncana/javascript/ezstarrating_jquery.js
extension/community_design/design/suncana/javascript/jquery.initboxes.js
extension/community_design/design/suncana/javascript/app.js
extension/community_design/design/suncana/javascript/twitterwidget.js
extension/community_design/design/suncana/javascript/community.js
extension/community_design/design/suncana/javascript/roadmap.js
extension/community_design/design/suncana/javascript/ez.js
extension/community_design/design/suncana/javascript/ezshareevents.js
extension/sevenx/design/simple/javascript/main.js

Templates used to render the page:

UsageRequested templateTemplateTemplate loadedEditOverride
1pagelayout.tpl<No override>extension/sevenx/design/simple/templates/pagelayout.tplEdit templateOverride template
 Number of times templates used: 1
 Number of unique templates used: 1

Time used to render debug report: 0.0002 secs