fromString for updating objects?

Previous topic

Developer

Next topic

Author	Message
Peter Keung	Monday 18 July 2011 12:56:14 pm We've been using datatypes' fromString methods for years now, for imports and updates. The "ezuser" datatype's fromString method does a check to make sure that the username and e-mail address don't already exist (see here for a bit of context: http://issues.ez.no/IssueView.php?Id=17836&activeItem=3). This makes it unsuitable to be used for updates to existing users. We use some simple workaround code to capture updates to "ezuser" attributes and update them directly -- not really a problem. However, this brings up a general framework question: Was the intention around fromString for it to be used on new object creation only? If it was also intended to be used in updates, then perhaps ezuser's fromString method should be modified to put the onus on the script using that method to do its own checks on the username or e-mail address. This way, the actual update process is more standardized: you are forced to do all of the necessary preparation on the attributes before they are passed through. http://www.mugo.ca Mugo Web, eZ Partner in Vancouver, Canada
Gaetano Giunta	Tuesday 19 July 2011 11:49:24 am I fully agree that the fromString method, while extremely useful, is not good enough. It is not supported by 100% of the datatypes It does not involve all of the validation done when editing content via the browser Point 2 is especially important, as there is currently no other method (afaik) that does it - datatype validation is sadly tied to variables being there in $_POST. This has the nasty effects that a lot of import scripts do create inconsistent data (inconsistent wrt. content class definition). Let's hope that this will be fixed in the new content-management API currently in the works... Principal Consultant International Business Member of the Community Project Board

Author

Message

Peter Keung

Monday 18 July 2011 12:56:14 pm

We've been using datatypes' fromString methods for years now, for imports and updates.

The "ezuser" datatype's fromString method does a check to make sure that the username and e-mail address don't already exist (see here for a bit of context: http://issues.ez.no/IssueView.php?Id=17836&activeItem=3). This makes it unsuitable to be used for updates to existing users. We use some simple workaround code to capture updates to "ezuser" attributes and update them directly -- not really a problem. However, this brings up a general framework question:

Was the intention around fromString for it to be used on new object creation only? If it was also intended to be used in updates, then perhaps ezuser's fromString method should be modified to put the onus on the script using that method to do its own checks on the username or e-mail address. This way, the actual update process is more standardized: you are forced to do all of the necessary preparation on the attributes before they are passed through.

http://www.mugo.ca
Mugo Web, eZ Partner in Vancouver, Canada

Gaetano Giunta

Tuesday 19 July 2011 11:49:24 am

I fully agree that the fromString method, while extremely useful, is not good enough.

It is not supported by 100% of the datatypes
It does not involve all of the validation done when editing content via the browser

Point 2 is especially important, as there is currently no other method (afaik) that does it - datatype validation is sadly tied to variables being there in $_POST. This has the nasty effects that a lot of import scripts do create inconsistent data (inconsistent wrt. content class definition).

Let's hope that this will be fixed in the new content-management API currently in the works...

Principal Consultant International Business
Member of the Community Project Board

eZ debug

Timing:	Jan 18 2025 02:07:43
Script start
Timing:	Jan 18 2025 02:07:43
Module start 'layout'
Timing:	Jan 18 2025 02:07:43
Module start 'content'
Timing:	Jan 18 2025 02:07:43
Module end 'content'
Timing:	Jan 18 2025 02:07:43
Script end

Main resources:

Total runtime	0.6635 sec
Peak memory usage	4,096.0000 KB
Database Queries	55

Timing points:

Checkpoint	Start (sec)	Duration (sec)	Memory at start (KB)	Memory used (KB)
Script start	0.0000	0.0055	587.9141	152.6250
Module start 'layout'	0.0055	0.0029	740.5391	39.4531
Module start 'content'	0.0084	0.6536	779.9922	537.8828
Module end 'content'	0.6619	0.0015	1,317.8750	12.1563
Script end	0.6634		1,330.0313

Time accumulators:

Accumulator	Duration (sec)	Duration (%)	Count	Average (sec)
Ini load
Load cache	0.0035	0.5265	16	0.0002
Check MTime	0.0014	0.2149	16	0.0001
Mysql Total
Database connection	0.0008	0.1198	1	0.0008
Mysqli_queries	0.6177	93.1090	55	0.0112
Looping result	0.0005	0.0749	53	0.0000
Template Total	0.6352	95.7	2	0.3176
Template load	0.0020	0.3083	2	0.0010
Template processing	0.6331	95.4288	2	0.3166
Template load and register function	0.0001	0.0146	1	0.0001
states
state_id_array	0.0011	0.1586	1	0.0011
state_identifier_array	0.0009	0.1325	2	0.0004
Override
Cache load	0.0017	0.2618	16	0.0001
Sytem overhead
Fetch class attribute can translate value	0.0005	0.0702	2	0.0002
Fetch class attribute name	0.0013	0.1892	4	0.0003
XML
Image XML parsing	0.0010	0.1472	2	0.0005
class_abstraction
Instantiating content class attribute	0.0000	0.0012	4	0.0000
General
dbfile	0.0010	0.1536	23	0.0000
String conversion	0.0000	0.0015	4	0.0000
Note: percentages do not add up to 100% because some accumulators overlap

Templates used to render the page:

Usage	Requested template	Template	Template loaded
1	node/view/full.tpl	full/forum_topic.tpl	extension/sevenx/design/simple/override/templates/full/forum_topic.tpl
2	content/datatype/view/ezimage.tpl	<No override>	extension/sevenx/design/simple/templates/content/datatype/view/ezimage.tpl
2	content/datatype/view/ezxmltext.tpl	<No override>	extension/community_design/design/suncana/templates/content/datatype/view/ezxmltext.tpl
4	content/datatype/view/ezxmltags/paragraph.tpl	<No override>	extension/ezwebin/design/ezwebin/templates/content/datatype/view/ezxmltags/paragraph.tpl
1	content/datatype/view/ezxmltags/link.tpl	<No override>	design/standard/templates/content/datatype/view/ezxmltags/link.tpl
1	content/datatype/view/ezxmltags/li.tpl	<No override>	design/standard/templates/content/datatype/view/ezxmltags/li.tpl
1	content/datatype/view/ezxmltags/ol.tpl	<No override>	design/standard/templates/content/datatype/view/ezxmltags/ol.tpl
1	print_pagelayout.tpl	<No override>	extension/community/design/community/templates/print_pagelayout.tpl
Number of times templates used: 13 Number of unique templates used: 8

Time used to render debug report: 0.0001 secs