Preferences Code

Next topic

Author	Message
Rob Clews	Monday 05 January 2004 3:47:36 am in kernel/classes/ezpreferences.php there is the following: $existingRes = $db->arrayQuery( "SELECT * FROM ezpreferences WHERE user_id = $userID" ); if ( count( $existingRes ) > 0 ) [...] $query = "UPDATE ezpreferences SET value='$value' WHERE id = $prefID AND name='$name'"; Unless I'm being stupid here, my understanding of the function is as follows. If there is not setting for $name in the database then insert it, if it exists update it. So surely that select is incorrect because if you have any preferences for the current user then count($existingRes) will be > 0, although the pref you are trying to save may not exist in the db. Ultimately, this only allows one preference to ever be set?
Rob Clews	Monday 05 January 2004 3:48:41 am Probably wasn't clear, but shouldn't the select query be: $existingRes = $db->arrayQuery( "SELECT * FROM ezpreferences WHERE user_id = $userID AND name='$name'" );
Paul Borgermans	Monday 05 January 2004 5:01:46 am Rob, This was fixed a while ago, on 2003-11-27 (3.2-4 and 3.3-1 should be OK) See also this bug report: http://ez.no/developer/ez_publish_3/bug_reports/ezpreferences_only_one_variable_can_be_stored_in_the_database_for_each_user eZ Publish, eZ Find, Solr expert consulting and training http://twitter.com/paulborgermans

Author

Message

Monday 05 January 2004 3:47:36 am

in kernel/classes/ezpreferences.php there is the following:

$existingRes = $db->arrayQuery( "SELECT * FROM ezpreferences WHERE user_id = $userID" );

if ( count( $existingRes ) > 0 )
[...]
$query = "UPDATE ezpreferences SET value='$value' WHERE id = $prefID AND name='$name'";

Unless I'm being stupid here, my understanding of the function is as follows. If there is not setting for $name in the database then insert it, if it exists update it. So surely that select is incorrect because if you have any preferences for the current user then count($existingRes) will be > 0, although the pref you are trying to save may not exist in the db.

Ultimately, this only allows one preference to ever be set?

Rob Clews

Monday 05 January 2004 3:48:41 am

Probably wasn't clear, but shouldn't the select query be:

$existingRes = $db->arrayQuery( "SELECT * FROM ezpreferences WHERE user_id = $userID AND name='$name'" );

Paul Borgermans

Monday 05 January 2004 5:01:46 am

Rob, This was fixed a while ago, on 2003-11-27 (3.2-4 and 3.3-1 should be OK)

eZ debug

Timing:	Jan 18 2025 22:30:17
Script start
Timing:	Jan 18 2025 22:30:17
Module start 'layout'
Timing:	Jan 18 2025 22:30:17
Module start 'content'
Timing:	Jan 18 2025 22:30:18
Module end 'content'
Timing:	Jan 18 2025 22:30:18
Script end

Main resources:

Total runtime	0.8030 sec
Peak memory usage	4,096.0000 KB
Database Queries	57

Timing points:

Checkpoint	Start (sec)	Duration (sec)	Memory at start (KB)	Memory used (KB)
Script start	0.0000	0.0101	588.9297	152.6094
Module start 'layout'	0.0101	0.0107	741.5391	39.4141
Module start 'content'	0.0208	0.7808	780.9531	532.9063
Module end 'content'	0.8016	0.0013	1,313.8594	12.1875
Script end	0.8029		1,326.0469

Time accumulators:

Accumulator	Duration (sec)	Duration (%)	Count	Average (sec)
Ini load
Load cache	0.0036	0.4521	16	0.0002
Check MTime	0.0014	0.1686	16	0.0001
Mysql Total
Database connection	0.0019	0.2329	1	0.0019
Mysqli_queries	0.7521	93.6642	57	0.0132
Looping result	0.0006	0.0700	55	0.0000
Template Total	0.7377	91.9	2	0.3688
Template load	0.0020	0.2436	2	0.0010
Template processing	0.7357	91.6247	2	0.3679
Template load and register function	0.0002	0.0271	1	0.0002
states
state_id_array	0.0012	0.1512	1	0.0012
state_identifier_array	0.0010	0.1304	2	0.0005
Override
Cache load	0.0016	0.1967	19	0.0001
Sytem overhead
Fetch class attribute can translate value	0.0006	0.0727	2	0.0003
Fetch class attribute name	0.0009	0.1171	4	0.0002
XML
Image XML parsing	0.0007	0.0842	2	0.0003
class_abstraction
Instantiating content class attribute	0.0000	0.0010	4	0.0000
General
dbfile	0.0008	0.1019	17	0.0000
String conversion	0.0000	0.0015	4	0.0000
Note: percentages do not add up to 100% because some accumulators overlap

Templates used to render the page:

Usage	Requested template	Template	Template loaded
1	node/view/full.tpl	full/forum_topic.tpl	extension/sevenx/design/simple/override/templates/full/forum_topic.tpl
3	content/datatype/view/ezxmltext.tpl	<No override>	extension/community_design/design/suncana/templates/content/datatype/view/ezxmltext.tpl
4	content/datatype/view/ezxmltags/paragraph.tpl	<No override>	extension/ezwebin/design/ezwebin/templates/content/datatype/view/ezxmltags/paragraph.tpl
1	content/datatype/view/ezxmltags/line.tpl	<No override>	design/standard/templates/content/datatype/view/ezxmltags/line.tpl
1	content/datatype/view/ezimage.tpl	<No override>	extension/sevenx/design/simple/templates/content/datatype/view/ezimage.tpl
1	print_pagelayout.tpl	<No override>	extension/community/design/community/templates/print_pagelayout.tpl
Number of times templates used: 11 Number of unique templates used: 6

Time used to render debug report: 0.0001 secs