question about ezgeneraldigesthandler.php

Previous topic

Developer

Next topic

Author	Message
Marko Žmak	Thursday 09 April 2009 2:21:54 am I have noticed in eZ 3.10.1 that in ezgeneraldigesthandler.php at line 245 there is this code: if ( $http->hasPostVariable( 'ReceiveDigest_' . EZ_GENERALDIGEST_NOTIFICATION_HANDLER_ID ) && $http->hasPostVariable( 'ReceiveDigest_' . EZ_GENERALDIGEST_NOTIFICATION_HANDLER_ID ) == '1' ) Why is the line: $http->hasPostVariable( 'ReceiveDigest_' . EZ_GENERALDIGEST_NOTIFICATION_HANDLER_ID ) == '1' here? Shouldn't this be: $http->PostVariable( 'ReceiveDigest_' . EZ_GENERALDIGEST_NOTIFICATION_HANDLER_ID ) == '1' so that the value of the post variable is checked and not it's exsistence? -- Nothing is impossible. Not if you can imagine it! Hubert Farnsworth

Author

Message

Marko Žmak

Thursday 09 April 2009 2:21:54 am

I have noticed in eZ 3.10.1 that in ezgeneraldigesthandler.php at line 245 there is this code:

        if ( $http->hasPostVariable( 'ReceiveDigest_' . EZ_GENERALDIGEST_NOTIFICATION_HANDLER_ID ) &&
             $http->hasPostVariable( 'ReceiveDigest_' . EZ_GENERALDIGEST_NOTIFICATION_HANDLER_ID ) == '1' )

Why is the line:

$http->hasPostVariable( 'ReceiveDigest_' . EZ_GENERALDIGEST_NOTIFICATION_HANDLER_ID ) == '1'

here? Shouldn't this be:

$http->PostVariable( 'ReceiveDigest_' . EZ_GENERALDIGEST_NOTIFICATION_HANDLER_ID ) == '1'

so that the value of the post variable is checked and not it's exsistence?

--
Nothing is impossible. Not if you can imagine it!

Hubert Farnsworth

eZ debug

Timing:	Jan 31 2025 00:41:09
Script start
Timing:	Jan 31 2025 00:41:09
Module start 'layout'
Timing:	Jan 31 2025 00:41:09
Module start 'content'
Timing:	Jan 31 2025 00:41:09
Module end 'content'
Timing:	Jan 31 2025 00:41:09
Script end

Main resources:

Total runtime	0.0240 sec
Peak memory usage	6,144.0000 KB
Database Queries	3

Timing points:

Checkpoint	Start (sec)	Duration (sec)	Memory at start (KB)	Memory used (KB)
Script start	0.0000	0.0048	588.2656	151.2266
Module start 'layout'	0.0048	0.0037	739.4922	220.7188
Module start 'content'	0.0085	0.0138	960.2109	997.8672
Module end 'content'	0.0223	0.0016	1,958.0781	29.9922
Script end	0.0239		1,988.0703

Time accumulators:

Accumulator	Duration (sec)	Duration (%)	Count	Average (sec)
Ini load
Load cache	0.0027	11.3098	14	0.0002
Check MTime	0.0011	4.4290	14	0.0001
Mysql Total
Database connection	0.0007	2.9451	1	0.0007
Mysqli_queries	0.0021	8.8113	3	0.0007
Looping result	0.0000	0.0458	1	0.0000
Template Total	0.0012	5.0	1	0.0012
Template load	0.0009	3.5667	1	0.0009
Template processing	0.0003	1.4024	1	0.0003
Override
Cache load	0.0006	2.4527	1	0.0006
General
dbfile	0.0011	4.6638	8	0.0001
String conversion	0.0000	0.0298	4	0.0000
Note: percentages do not add up to 100% because some accumulators overlap

Templates used to render the page:

Usage	Requested template	Template	Template loaded	Edit	Override
1	print_pagelayout.tpl	<No override>	extension/community/design/community/templates/print_pagelayout.tpl
Number of times templates used: 1 Number of unique templates used: 1

Time used to render debug report: 0.0001 secs