Worldpay gateway added

Thursday 03 March 2005 4:10:13 am

Hi Paul,

Around line 105 in modules/worldpay/callback.php, I find the following code:

//Local ini file installationID
           if ( $ini->hasVariable( "Worldpay", "InstallID" ) )
            $local_install_id = $ini->variableArray( "Worldpay", "InstallID" );

           //Make sure they match
           if ( $wpinst_id == $local_install_id )
           return true;

Shouldn't the the ini object call the variable() method instead of variableArray(), or am I missing something here?

Sincerely,

Eirik Alfstad Johansen
http://www.netmaking.no/

Thursday 03 March 2005 5:19:47 am

Hi Paul,

As you might have guessed, I'm working on implementing your worldpay extension again, since I never quite got it running the first time.

Now, I've run into some problems with the callback view, and more specifically, the isAmountOK() function. The problem is that this function expects to find the following variables in my xrate.ini file:

GBP_GBP
GBP_EUR
GBP_USD

whereas my file only contains a value for the variable NOK_NOK (since we are only accepting Norwegian kroner).

I suspect that something is hard coded here that shouldn't be, but since I'm having a hard time understanding the purpose of this function, I'm unable to correct it myself.

Could you please take a look? Thanks in advance !

Sincerely,

Eirik Alfstad Johansen
http://www.netmaking.no/

Sunday 13 March 2005 7:36:52 am

Hello,
Are there any plans to also integrate FuturePay in the near future?

Monday 14 March 2005 11:44:44 am

Since i need it, it looks like i gonna have to develop a solution on my own. At least until your extension is ready.

I have the read the docs from worldpay on SelectJunior and FuturePay.
I plan to create a new extension based on your work, but with the additions to the form needed to get FuturePay to work.
I dont know yet what else needs to be changed in your code, but i will start to read through it.
As i plan to use both extensions, but for different sections of the site, i thought i could implement that with an multiplexer workflow.

Any suggestions on things i should consider or on the general plan are appreciated!

Wednesday 16 March 2005 3:57:03 am

The reason for the matrix datatype was because different clients needed different fields. To put these fields into a class would then have consequences for the extension which would rely on those attributes being present. Instead we chose the matrix datatype which allows more flexibility.

Admittedly it isnt always needed :) Plus the design choice is a few years old. I can see a few ways to improve it.

If you want to remove the matrix datatype just make sure you reference the correct attributes in the extension. Its only an address after all ;)

paul

Monday 08 August 2005 5:38:13 am

Hi Eirek,

Does your anon user have permissions to view that module view? :)

We are actually in the middle of trying out anon registration with worldpay, using shop/userregister. I'll post if there are problems.

Paul

Monday 08 August 2005 6:45:23 am

Hi Eirik,

You need to give the Anon user access to shop|orderview as well.

-Bo

Tuesday 09 August 2005 3:14:49 am

Yes, you are right. It isnt an option in 3.5. Orderview is linked to the 'buy' permission.

The orderview code does perform an explicit check on the session (kernel/shop/orderview.php):

        if( $OrderID != $http->sessionVariable( 'UserOrderID' ) )
        {
            $access = false;
        }

One thing you could try is to disable sessions per siteaccess. This 'may' keep the same session when worldpay returns:

[Session]
SessionNamePerSiteAccess=disabled

Although it might not.

You could patch orderview.php with a different check for access.

paul

Friday 13 January 2006 3:03:55 am

FYI, we've refreshed the worldpay extension for 3.5 and above. The contrib area and pubsvn have been updated.

Paul