Ezapprove2 improvements

Author Message

Matteo Mosangini

Wednesday 22 July 2009 2:22:23 am

Hi,

this is my first post in this forum.
I'm working on ezapprove2 extension you can find the code here:

https://git.e-moka.net/?p=approve2.git;a=summary

modifications:

- when you deny an object it is sent back to the author as a draft
- exclusion groups are applied even when you let your users select their approvers
- when an approver edits an item it is immediately published
- cleanup collaboration tables
- Italian translation
- template update

Heath

Wednesday 22 July 2009 4:20:30 am

Good to hear!

I also have an interest in these improvements.

Please drop an update as your changes evolve.

Cheers,
Heath

Brookins Consulting | http://brookinsconsulting.com/
Certified | http://auth.ez.no/certification/verify/380350
Solutions | http://projects.ez.no/users/community/brookins_consulting
eZpedia community documentation project | http://ezpedia.org

Matteo Mosangini

Thursday 23 July 2009 5:56:47 am

Extension updated!
Check out commit history:)

James

Thursday 23 July 2009 6:17:46 am

Wow that is an impressive collection of updates, congratulations.

[0] <i>https://git.e-moka.net/?p=approve2.git;a=blobdiff;f=eventtypes/event/ezapprove2/ezapprove2type.php;h=6f7448987a9a2db1af8ac03b2b20ee8c310d063d;hp=76c5cdf7e54ed91c73fe483732df66e27467628e;hb=289130036f2b7d1bfe8afde1b0f4e0026526fbff;hpb=e32f4a75180ec7b163ebe39b435fbce17b7734ef</i>

I'm not sure if the link will store correctly since its so unique but this is a direct link to a diff between first and current latest version of a primary ezapprove2 workflow event php file. The following is a changelog view.

[1] <i>https://git.e-moka.net/?p=approve2.git;a=log;h=1a4c0f10d4c17ca20b8a2875d93ebe888dc7a690</i>

Matteo Mosangini

Friday 24 July 2009 12:45:27 am

Webdav support in eZApprove2Event::ApproveTypeUser added.

Matteo Mosangini

Tuesday 18 August 2009 1:56:41 pm

Added configuration setting to enable per user class pre selection of approvers start browse node (during approvers selection)
Added template path in ezapprove2type

Heath

Wednesday 19 August 2009 12:47:25 am

Hello Matteo,

You have I wonder if you would consider speaking with YMC

Regarding collaboration on setting up a public mirror of your repository through, http://git.forge.ymc.ch/

This would ensure the community would not risk loosing these contributions in the future.

What do you think?

Cheers,
Heath

[0] http://ezpedia.org/ez/git
[1] http://git.forge.ymc.ch/

Brookins Consulting | http://brookinsconsulting.com/
Certified | http://auth.ez.no/certification/verify/380350
Solutions | http://projects.ez.no/users/community/brookins_consulting
eZpedia community documentation project | http://ezpedia.org

Matteo Mosangini

Thursday 27 August 2009 10:55:01 am

This could be very nice:)
Now I'm very busy, next week I'll try to speak to YMC.

Matteo Mosangini

Saturday 05 September 2009 6:06:10 am

I've contacted Ymc and now I'm waiting for an answer.

Meanwhile I added the possibility to save a list of previously used approvers (per user) to use during approvers selection

Thomas Koch

Sunday 06 September 2009 6:42:38 am

Hi Matteo,

I've cloned your repository at
http://git.forge.ymc.ch/
It'll be updated every 2 hours.

Please note, that this is an unofficial service of YMC and may (and will) change without warning. We're happy to help you (and the community) out with a backup.
However, since GIT is distributed, there's no reason not to put another backup for example at github, as I've done with eZ Components:
http://github.com/thkoch2001

Could you please add license information to the code so that's clear that we may actually distribute it?

---
Thomas Koch | http://koch.ro
YMC - eZ Publish in Switzerland | http://ymc.ch

Matteo Mosangini

Monday 07 September 2009 8:41:10 am

Hi Thomas,
I added license information, thank you very much for cloning my rep.

Jérôme Vieilledent

Thursday 07 January 2010 12:38:27 am

Hi

It would be interesting to have your changes committed in the original project repository, wouldn't it ?

Pablo Pernot

Friday 02 April 2010 1:44:00 am

"

Hi

It would be interesting to have your changes committed in the original project repository, wouldn't it ?

"

+1

Pablo Pernot
http://www.smartview.fr
http://www.areyouagile.com

Pablo Pernot

Friday 02 April 2010 5:21:48 am

Hum....

[ Apr 02 2010 14:15:27 ] [::1] eZMySQLDB:Query error: La table '*******.ezx_chosen_approver' n'existe pas. Query: SELECT id, user_id, approver_user_id FROM ezx_chosen_approverWHERE user_id='1030'

obviously the table ezx_chosen_approver is missing ? No table with that name un sql/schema.sql

any hints ?

Pablo Pernot
http://www.smartview.fr
http://www.areyouagile.com

Pablo Pernot

Friday 02 April 2010 5:29:16 am

hum... twice

probably a mistake from me

I find that :

https://git.e-moka.net/?p=approve2.git;a=blob;f=sql/mysql/ezx_chosen_approver.sql;h=be1b201216843ab00ec57d19b91e83bb9208a4b7;hb=e0e86d391baf161db9dcf71b4ee8d9c467251c7e

Pablo Pernot
http://www.smartview.fr
http://www.areyouagile.com

Samuel Torton

Tuesday 12 October 2010 2:15:19 pm

Hi Matteo,
I'm really interested in your eZ Approve 2 improvements. I will test it.
I have a concern regarding the 2 following improvements:
-1- exclusion groups are applied even when you let your users select their approvers
-2- when an approver edits an item it is immediately published
I really want NOT TO APPLY the point -2-, except if the approver is a member of -1-.
Could you please give me the hint concerning this point? And I will modify the code to meet my requirements.
Thank you,

Samuel Torton

Powered by eZ Publish™ CMS Open Source Web Content Management. Copyright © 1999-2014 eZ Systems AS (except where otherwise noted). All rights reserved.

eZ debug

Timing: Jan 18 2025 02:56:55
Script start
Timing: Jan 18 2025 02:56:55
Module start 'layout'
Timing: Jan 18 2025 02:56:55
Module start 'content'
Timing: Jan 18 2025 02:56:56
Module end 'content'
Timing: Jan 18 2025 02:56:56
Script end

Main resources:

Total runtime0.6082 sec
Peak memory usage4,096.0000 KB
Database Queries109

Timing points:

CheckpointStart (sec)Duration (sec)Memory at start (KB)Memory used (KB)
Script start 0.00000.0053 587.9063152.6250
Module start 'layout' 0.00530.0031 740.531339.4453
Module start 'content' 0.00850.5983 779.9766919.3438
Module end 'content' 0.60680.0014 1,699.320332.1719
Script end 0.6082  1,731.4922 

Time accumulators:

 Accumulator Duration (sec) Duration (%) Count Average (sec)
Ini load
Load cache0.00310.5019160.0002
Check MTime0.00130.2102160.0001
Mysql Total
Database connection0.00100.160810.0010
Mysqli_queries0.487080.06561090.0045
Looping result0.00120.18981070.0000
Template Total0.578495.120.2892
Template load0.00180.294020.0009
Template processing0.576694.805320.2883
Template load and register function0.00010.020910.0001
states
state_id_array0.00090.139910.0009
state_identifier_array0.00160.267020.0008
Override
Cache load0.00200.32881060.0000
Sytem overhead
Fetch class attribute can translate value0.00090.141170.0001
Fetch class attribute name0.00140.2252220.0001
XML
Image XML parsing0.00590.976170.0008
class_abstraction
Instantiating content class attribute0.00010.0103310.0000
General
dbfile0.00430.7060480.0001
String conversion0.00000.000940.0000
Note: percentages do not add up to 100% because some accumulators overlap

Templates used to render the page:

UsageRequested templateTemplateTemplate loadedEditOverride
1node/view/full.tplfull/forum_topic.tplextension/sevenx/design/simple/override/templates/full/forum_topic.tplEdit templateOverride template
15content/datatype/view/ezimage.tpl<No override>extension/sevenx/design/simple/templates/content/datatype/view/ezimage.tplEdit templateOverride template
16content/datatype/view/ezxmltext.tpl<No override>extension/community_design/design/suncana/templates/content/datatype/view/ezxmltext.tplEdit templateOverride template
27content/datatype/view/ezxmltags/paragraph.tpl<No override>extension/ezwebin/design/ezwebin/templates/content/datatype/view/ezxmltags/paragraph.tplEdit templateOverride template
12content/datatype/view/ezxmltags/line.tpl<No override>design/standard/templates/content/datatype/view/ezxmltags/line.tplEdit templateOverride template
3content/datatype/view/ezxmltags/link.tpl<No override>design/standard/templates/content/datatype/view/ezxmltags/link.tplEdit templateOverride template
1content/datatype/view/ezxmltags/quote.tpldatatype/ezxmltext/quote.tplextension/ezwebin/design/ezwebin/override/templates/datatype/ezxmltext/quote.tplEdit templateOverride template
1print_pagelayout.tpl<No override>extension/community/design/community/templates/print_pagelayout.tplEdit templateOverride template
 Number of times templates used: 76
 Number of unique templates used: 8

Time used to render debug report: 0.0001 secs