Images with gd

Wednesday 04 June 2003 9:23:37 pm

What problems do you have?
No images at all or error/warnings?

Thursday 05 June 2003 10:54:53 am

a quick look:
I think somethings wrong with the wwwdir var in ezsys.php. It is read from php server variables (see source of ezsys.php) but in your case empty.
This why the reference dir is var/storage/reference/image/ instead of /home/ez/public_html/var/storage/reference/image/

Are you using some kind of uncommon server/configuration?

Thursday 05 June 2003 10:30:56 pm

EZ creates a reference image first, from that reference image other variations are converted.
Something goes wrong when creating the reference image, because it does not seem to exist. Though I don't think the extra slash would be the problem

> When is the image created or copied to the reference dir? i can't find it.
It starts in kernel/classes/datatypes/ezimage/ezimagevariation.php

Friday 06 June 2003 11:38:16 am

this is from the 3.0-2 code straight off the web site.

i finaly got it work work with gd but i think not it wont work with imagmagick.

see next message

Friday 06 June 2003 1:14:27 pm

More acuratly her is a diff

diff -urN kernel/classes/datatypes/ezimage/ezimagevariation.php /home/ez/public_html/kernel/classes/datatypes/ezimage/ezimagevariation.php
--- kernel/classes/datatypes/ezimage/ezimagevariation.php 2003-04-24 09:08:07.000000000 -0400
+++ /home/ez/public_html/kernel/classes/datatypes/ezimage/ezimagevariation.php 2003-06-06 15:45:53.000000000 -0400
@@ -205,23 +205,19 @@
false
);

- $refImageFilename = explode( ':', $refImagename);
- $refImagename = $variationPath . '/' . $additionalPath . '/' . $refImageFilename[ 1 ];
+ $imageFullPath = $variationPath . '/' . $additionalPath . '/'. $refImagename;

- $imgsize = getimagesize ( $refImagename );
- unset( $refImagename );
+ $imgsize = getimagesize ( $imageFullPath );

$imageVariation = new eZImageVariation( array("contentobject_attribute_id" => $ezimageobj->attribute( "contentobject_attribute_id" ),
"version" => $ezimageobj->attribute( "version" ),
- "filename" => $refImageFilename[1],
+ "filename" => $refImagename,
"additional_path" => $additionalPath,
"requested_width" => $rwidth,
"requested_height" => $rheight,
"width" => $imgsize[0],
"height" => $imgsize[1] ) );

- $imageFullPath = $variationPath . '/' . $additionalPath . '/' . $refImageFilename[1];
-

if ( filesize( $imageFullPath ) == 0 || !file_exists( $imageFullPath ) )
{
diff -urN kernel/common/image.php /home/ez/public_html/kernel/common/image.php
--- kernel/common/image.php 2003-04-24 09:08:12.000000000 -0400
+++ /home/ez/public_html/kernel/common/image.php 2003-06-06 15:37:00.000000000 -0400
@@ -91,7 +91,7 @@
if ( $useGD )
{
$img->registerType( 'gd', new eZImageGD( EZ_IMAGE_KEEP_SUFFIX,
- EZ_IMAGE_PREPEND_SUFFIX_TAG ) );
+ EZ_IMAGE_KEEP_SUFFIX ) );
}

// Output types
diff -urN lib/ezimage/classes/ezimagegd.php /home/ez/public_html/lib/ezimage/classes/ezimagegd.php
--- lib/ezimage/classes/ezimagegd.php 2003-04-24 09:08:20.000000000 -0400
+++ /home/ez/public_html/lib/ezimage/classes/ezimagegd.php 2003-06-06 15:38:08.000000000 -0400
@@ -157,7 +157,7 @@
}
$src = "";
$dst = "";
- $to_dst = $from;
+ $to_dst = $to;
$to_dst["suffix"] = $to["suffix"];
$src .= $this->convertFileName( $from, $this->FromType );
$dst .= $this->convertFileName( $to_dst, $this->ToType );
@@ -193,9 +193,9 @@
/*!
Calls convert() with the $filters and $scale param.
*/
- function scale( &$from, &$to, &$to_file, &$filters, $scale )
+ function scale( &$from, &$to, &$to_dir, &$to_file, &$filters, $scale )
{
- $this->convert( $from, $to, $to_file, $filters, $scale );
+ $this->convert( $from, $to, $to_dir, $to_file, $filters, $scale );
}

/// Array of allowed input types mapped to the corresponding function.
diff -urN lib/ezimage/classes/ezimagemanager.php /home/ez/public_html/lib/ezimage/classes/ezimagemanager.php
--- lib/ezimage/classes/ezimagemanager.php 2003-04-24 09:08:21.000000000 -0400
+++ /home/ez/public_html/lib/ezimage/classes/ezimagemanager.php 2003-06-06 15:39:17.000000000 -0400
@@ -328,10 +328,10 @@
$this->addFilterRule( $rules, true );
$suffix = $mime["suffix"];
$dirs = "";
- if ( preg_match( "#(.+/)?(.+)$#", $file, $matches ) )
+ if ( preg_match( "#((.+)/)?(.+)$#", $file, $matches ) )
{
- $dirs = $matches[1];
- $file = $matches[2];
+ $dirs = $matches[2];
+ $file = $matches[3];
}
$base = $file;
if ( preg_match( "/(.+)" . $mime["match"] . "/i", $file, $matches ) )
@@ -348,10 +348,10 @@
{
$dest_dirs = "";
$dest_file = $dest;
- if ( preg_match( "#(.+/)?(.+)$#", $dest, $matches ) )
+ if ( preg_match( "#((.+)/)?(.+)$#", $dest, $matches ) )
{
- $dest_dirs = $matches[1];
- $dest_file = $matches[2];
+ $dest_dirs = $matches[2];
+ $dest_file = $matches[3];
}
$dest_base = $dest_file;
if ( preg_match( "/(.+)" . $mime["match"] . "/i", $dest_file, $matches ) )
@@ -410,7 +410,7 @@
list( $mimeType, $storedFileName ) = split(":", $to_file );
eZLog::writeStorageLog( $storedFileName, $dest_dirs );

- return $from_array["dir"] . "/" . $out_file;
+ return $out_file;
}

/*!

Wednesday 11 June 2003 2:58:08 pm

copy the above diff into a file eg. ezimage.diff

move that file into your ezpublish directory

use patch -p5 < ezimage.diff

you may have to change -p5 to -psomeothernumber where someothernumber

-pnum or --strip=num
Strip the smallest prefix containing num leading slashes from each
file name found in the patch file. A sequence of one or more adja-
cent slashes is counted as a single slash. This controls how file
names found in the patch file are treated, in case you keep your
files in a different directory than the person who sent out the
patch. For example, supposing the file name in the patch file was

/u/howard/src/blurfl/blurfl.c

setting -p0 gives the entire file name unmodified, -p1 gives

Wednesday 11 June 2003 3:42:31 pm

Hi,

ok, I've copied your listing into a file and moved it into my eZ publish directory (/data/apache/ezpublish-3.0-2) and I've tried all possible combinations of -pnum for the patch command but it doesn't work.

With -p0 it seems as if patch would find the correct file but I'm getting the following error message:

patching file kernel/classes/datatypes/ezimage/ezimagevariation.php
patch: **** malformed patch at line 5: false

Do you know what went wrong?

Dirk

Wednesday 11 June 2003 4:01:22 pm

Hmm, I could try it.

Or could you send it to me via email to dbl99@gmx.de?

TIA.

Regards,

Dirk

Thursday 12 June 2003 8:04:39 am

Follow this link to my patch.
http://ez.mojothing.com/

This is the only way I was able to get gd to work for posting images.

The patch fixes

1. trailing slashes in ezimagemanager
2. return only filename not path and filename in ezimagemanager.php(this messes ezimagevariation up as ezimagevariation adds the path again to the results from ezimagemanager)
3. ezimagevariation.php assumes image type is prefixed to the image name witch is no the case when using gd.
4. change image.ini to default to use gd
5. change ezimagegd.php - fix parameters to function scale and changed $to_dst = from to $to_dst=$to(makes a little more sense)
6. changed ezimagedg to scale propartionaly

NOTE:
This will make gd work but may break imagemagick.(Specificaly where ezimage variation makes the assumption the the file name is like jpg:/var/storage/image.jpg the prefixed jpg: is the problem)