RSS Import identifiers

Author Message

Adrien Dupuis

Wednesday 13 October 2010 2:42:09 am

I have found in 4.3.0 rssimport cronjob (24-Sep-2003 16:09:21 sp) how identifier are generated and I don't understand the priority choice.
From my point of view, "guid, title, link" could be more practical than "link, guid". GUID (Globally Unique IDentifier) first seems common sens.

rssimport.php, lines 209-227:

// Test for link or guid as unique identifier
$link = $item->getElementsByTagName( 'link' )->item( 0 );
$guid = $item->getElementsByTagName( 'guid' )->item( 0 );
if ( $link->textContent )
{
$md5Sum = md5( $link->textContent );
}
elseif ( $guid->textContent )
{
$md5Sum = md5( $guid->textContent );
}
else
{
if ( !$isQuiet )
{
$cli->output( 'RSSImport '.$rssImport->attribute( 'name' ).': Item has no unique identifier. RSS guid or link missing.' );
}
return 0;
}

Heath

Wednesday 13 October 2010 4:30:22 am

Adrien,

A better place to report issues is the issue tracker at http://issues.ez.no

Cheers,

Heath

Brookins Consulting | http://brookinsconsulting.com/
Certified | http://auth.ez.no/certification/verify/380350
Solutions | http://projects.ez.no/users/community/brookins_consulting
eZpedia community documentation project | http://ezpedia.org

André R.

Wednesday 13 October 2010 4:35:04 am

It is probably this issue:

#014256: About RemoteID of items created by rssimport.php

http://issues.ez.no/IssueView.php?Id=14256&activeItem=10

eZ Online Editor 5: http://projects.ez.no/ezoe || eZJSCore (Ajax): http://projects.ez.no/ezjscore || eZ Publish EE http://ez.no/eZPublish/eZ-Publish-Enterprise-Subscription
@: http://twitter.com/andrerom

Adrien Dupuis

Wednesday 13 October 2010 5:56:26 am

Thank to both of you. I've bookmarked the Issue Tracker. To me, it's not a bug so I've only suggested to do things differently. I also understand why it will be difficult to change this with backward compatibility.

I made my own patch to have the title as a possible identifier.

Now, I ask myself how I will determine if what I have to suggest got to go into Suggestion Forum or into Issue Tracker 's Enhancement type... ;)

Powered by eZ Publish™ CMS Open Source Web Content Management. Copyright © 1999-2014 eZ Systems AS (except where otherwise noted). All rights reserved.